Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.enum: allow using functional syntax for enum creation. #942

Merged
merged 1 commit into from
Oct 21, 2023
Merged

lib.enum: allow using functional syntax for enum creation. #942

merged 1 commit into from
Oct 21, 2023

Conversation

wanda-phi
Copy link
Member

Fixes #910.

@wanda-phi wanda-phi requested a review from whitequark as a code owner October 20, 2023 16:12
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #942 (cbb6ae6) into main (dacbd9d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #942   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files          54       54           
  Lines        7686     7686           
  Branches     1868     1868           
=======================================
  Hits         6437     6437           
+ Misses       1049     1048    -1     
- Partials      200      201    +1
Files Coverage Δ
amaranth/lib/enum.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

whitequark
whitequark approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@whitequark whitequark added this to the 0.4 milestone Oct 21, 2023
@whitequark whitequark added this pull request to the merge queue Oct 21, 2023
Merged via the queue into amaranth-lang:main with commit 00699f7 Oct 21, 2023
14 checks passed
@wanda-phi wanda-phi deleted the fix-func-enum branch October 22, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

amaranth.lib.enum does not support functional syntax
2 participants
@wanda-phi @whitequark